mobile: Don't activate previous logging context on engine destruction #37833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the StrippedMainBase destructor is invoked in Envoy Mobile engine destruction, occassionally the program crashes first due to trying to activate the previous saved logging Context. There's a race condition with accessing the static Context and its own destructor being invoked. This change allows Envoy Mobile's use of StrippedMainBase to avoid those crash issues by not trying to reactivate the previous saved logging Context on engine destruction, since it wouldn't be useful to the library anyway. Signed-off-by: Ali Beyad <[email protected]>
abeyad
requested review from
RyanTheOptimist,
alyssawilk and
fredyw
as code owners
|
/assign @alyssawilk |
|
cc @RenjieTang |
Signed-off-by: Ali Beyad <[email protected]>
abeyad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the StrippedMainBase destructor is invoked in Envoy Mobile engine destruction, occassionally the program crashes first due to trying to activate the previous saved logging Context. There's a race condition with accessing the static Context and its own destructor being invoked.
This change allows Envoy Mobile's use of StrippedMainBase to avoid those crash issues by not trying to reactivate the previous saved logging Context on engine destruction, since it wouldn't be useful to the library anyway.