Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: update credential provider proto and support credential file reload #37834

Merged
merged 6 commits into from
Jan 2, 2025

Conversation

nbaws
Copy link
Contributor

@nbaws nbaws commented Dec 28, 2024

Commit Message: aws: update credential provider proto and support credential file reload
Additional Description: Allows for customisation of the credential provider settings, using the credential provider proto added in #36217
Risk Level: Low
Testing: Unit
Docs Changes: Updated
Release Notes: Updated
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Addresses #36769 and partially addresses #37432
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Nigel Brittain <[email protected]>
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #37834 was opened by nbaws.

see: more, trace.

@nbaws
Copy link
Contributor Author

nbaws commented Dec 28, 2024

@mathetake

Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
@nbaws
Copy link
Contributor Author

nbaws commented Dec 28, 2024

/retest

Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
@mattklein123 mattklein123 merged commit 4d96cc2 into envoyproxy:main Jan 2, 2025
24 of 25 checks passed
@repokitteh-read-only repokitteh-read-only bot removed the api label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants