Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xDS docs: clarify that nonce is per-resource-type in ADS #37835

Merged

Conversation

markdroth
Copy link
Contributor

@markdroth markdroth commented Dec 28, 2024

Commit Message: xDS docs: clarify that nonce is per-resource-type in ADS
Additional Description: Documentation fix.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A

CC @ejona86

Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #37835 was opened by markdroth.

see: more, trace.

@markdroth markdroth changed the title xDS: clarify that nonce is per-resource-type in ADS xDS docs: clarify that nonce is per-resource-type in ADS Dec 28, 2024
@markdroth
Copy link
Contributor Author

/retest

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@repokitteh-read-only repokitteh-read-only bot removed the api label Jan 2, 2025
@adisuissa adisuissa merged commit 7ee3674 into envoyproxy:main Jan 2, 2025
25 checks passed
adisuissa pushed a commit that referenced this pull request Jan 2, 2025
@markdroth markdroth deleted the xds_spec_nonce_per_resource_type branch January 2, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants