Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove unused dependency from BUILD targets #37843

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

agrawroh
Copy link
Contributor

Description

This PR removes an unused dependency from multiple BUILD targets and header files.


Commit Message: remove unused dependency from BUILD targets
Additional Description: This PR removes unused dependency from multiple header and BUILD files.
Risk Level: Very Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

@agrawroh
Copy link
Contributor Author

/retest

@ravenblackx
Copy link
Contributor

I manually retriggered CodeQL-Build and it still failed the same way. Doesn't look like it's directly related to your PR, maybe try syncing up to head?

@ravenblackx ravenblackx self-assigned this Jan 2, 2025
@agrawroh
Copy link
Contributor Author

agrawroh commented Jan 2, 2025

I manually retriggered CodeQL-Build and it still failed the same way. Doesn't look like it's directly related to your PR, maybe try syncing up to head?

@ravenblackx I tried syncing with upstream but it's still failing with the same error :|

@agrawroh
Copy link
Contributor Author

agrawroh commented Jan 2, 2025

/retest

@ravenblackx
Copy link
Contributor

/retest

Not quite the same error, but another "absl missing its own internal dependencies" error. This looks similar, I suspect something is off in the build system (bad cache or incompatible versions, kinda thing). I don't know how to unblock though.

@ravenblackx
Copy link
Contributor

Looks like we can just ignore this if we're confident this PR is not causing it, and I'm pretty confident of that.

@ravenblackx ravenblackx merged commit 4a570b8 into envoyproxy:main Jan 2, 2025
24 of 25 checks passed
ravenblackx pushed a commit that referenced this pull request Jan 2, 2025
## Description

This PR removes an unused dependency from multiple BUILD targets and
header files.

---

**Commit Message**: remove unused dependency from BUILD targets
**Additional Description:** This PR removes unused dependency from
multiple header and BUILD files.
**Risk Level:** Very Low
Testing: N/A
**Docs Changes:** N/A
**Release Notes:** N/A

Signed-off-by: Rohit Agrawal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants