reverse_conn: envoy contrib changes for reverse_connection custom cluster #37932
Conversation
…ster Signed-off-by: Basundhara Chakrabarty <[email protected]>
|
Hi @basundhara-c, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Signed-off-by: Basundhara Chakrabarty <[email protected]>
|
/retest |
|
@botengyao anything blocking moving forward with a review? |
|
ping @botengyao |
| } | ||
|
|
||
| Upstream::HostSharedPtr RevConCluster::checkAndCreateHost(const std::string host_id) { | ||
| host_map_lock_.ReaderLock(); |
There was a problem hiding this comment.
usually we don't need a lock for the cluster since Envoy will maintain the thread-local cluster for each worker, but I think this cluster could be shared with all worker threads, and it is hard for me to understand how it is used, could you add more info to the class comments? It is fine not include thorough tests in contrib, could you point me maybe any integration/e2e test that involves this component but could not in this PR for me to understand, please?
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
Signed-off-by: Basundhara Chakrabarty <[email protected]>
Signed-off-by: Basundhara Chakrabarty <[email protected]>
Signed-off-by: Basundhara Chakrabarty <[email protected]>
github-actions
bot
removed
the
stale
Signed-off-by: Basundhara Chakrabarty <[email protected]>
Commit Message: This PR defines a new custom cluster type "envoy.clusters.reverse_connection" which enables requests to be sent over reverse connections instead of forward connections. This PR is strictly tied with #37368.
Additional Description: In order to differentiate between requests that need to be sent via a reverse connection vs those to be sent through forward connections, a new cluster type has been defined. The downstream requests to be sent over reverse connections are expected to contain either of the HTTP headers defined in the cluster's typed config, to enable upstream envoy to figure out which downstream node to send the request to,
The Cluster Manager checks whether the connection is intended for a reverse connection cluster, and if so, calls a custom HTTP/2 conn pool to send the request over the reverse connection.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]