Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update AWS config reference to use literalincludes #38231

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

albere
Copy link
Contributor

@albere albere commented Jan 28, 2025

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/38231/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: #38231 was opened by albere.

see: more, trace.

Copy link

Hi @albere, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #38231 was opened by albere.

see: more, trace.

@phlax
Copy link
Member

phlax commented Jan 28, 2025

@suniltheta @juanmolle we have move the example configs out to bootstrap files

the configs are valid - at least for envoy ci - but im not sure if they make sense overall

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks!

@phlax for a final review.

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @albere

@phlax phlax merged commit 3f6a0cb into envoyproxy:main Feb 3, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants