cors filter: add vary origin header #38868
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suresh Kumar Ponnusamy <[email protected]> Signed-off-by: Suresh Kumar Ponnusamy <[email protected]>
Signed-off-by: Suresh Kumar Ponnusamy <[email protected]> Signed-off-by: Suresh Kumar Ponnusamy <[email protected]>
wbpcode
reviewed
Mar 26, 2025
Comment on lines
+197
to
+200
| // Add Vary: Origin header when origin is not "*" | ||
| if (latched_origin_ != "*") { | ||
| headers.appendCopy(Http::CustomHeaders::get().Vary, "origin"); | ||
| } |
There was a problem hiding this comment.
What will happen if the upstream reponse header has set vary:origin ?
I think you can take the CompressorFilter::insertVaryHeader of /source/source/extensions/filters/http/compressor/compressor_filter.cc as an example about how to update the vary origin.
wbpcode
reviewed
Mar 26, 2025
|
/wait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: cors filter: add vary origin header
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #35873]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]