Skip to content

Commit df9e1b5

Browse files
committed
fix logs
Signed-off-by: zirain <[email protected]>
1 parent 7cc1b6e commit df9e1b5

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

internal/gatewayapi/runner/runner.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ func (r *Runner) startWasmCache(ctx context.Context) {
127127
func (r *Runner) subscribeAndTranslate(sub <-chan watchable.Snapshot[string, *resource.ControllerResources]) {
128128
message.HandleSubscription(message.Metadata{Runner: r.Name(), Message: message.ProviderResourcesMessageName}, sub,
129129
func(update message.Update[string, *resource.ControllerResources], errChan chan error) {
130-
r.Logger.Info("received an update")
130+
r.Logger.Info("received an update", "key", update.Key)
131131
val := update.Value
132132
// There is only 1 key which is the controller name
133133
// so when a delete is triggered, delete all IR keys

internal/provider/kubernetes/controller.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ func (r *gatewayAPIReconciler) Reconcile(ctx context.Context, _ reconcile.Reques
307307
return reconcile.Result{}, err
308308
}
309309

310-
r.log.Error(err, fmt.Sprintf("failed processGatewayClassParamsRef for gatewayClass %s", managedGC.Name))
310+
r.log.Error(err, "failed to process ParamsRef for gatewayClass", "gatewayClass", managedGC.Name)
311311
msg := fmt.Sprintf("%s: %v", status.MsgGatewayClassInvalidParams, err)
312312
gc := status.SetGatewayClassAccepted(
313313
managedGC.DeepCopy(),
@@ -330,7 +330,7 @@ func (r *gatewayAPIReconciler) Reconcile(ctx context.Context, _ reconcile.Reques
330330
return reconcile.Result{}, err
331331
}
332332

333-
r.log.Error(err, fmt.Sprintf("failed process TLS SecretRef for EnvoyProxy for gatewayClass %s", managedGC.Name))
333+
r.log.Error(err, "failed process TLS SecretRef for EnvoyProxy for gatewayClass", "gatewayClass", managedGC.Name)
334334
gc := status.SetGatewayClassAccepted(
335335
managedGC.DeepCopy(),
336336
false,
@@ -346,6 +346,7 @@ func (r *gatewayAPIReconciler) Reconcile(ctx context.Context, _ reconcile.Reques
346346

347347
if !failToProcessGCParamsRef {
348348
// GatewayClass is valid so far, mark it as accepted.
349+
r.log.Info("Set GatewayClass Accepted", "gatewayClass", managedGC.Name)
349350
gc := status.SetGatewayClassAccepted(
350351
managedGC.DeepCopy(),
351352
true,
@@ -498,16 +499,15 @@ func (r *gatewayAPIReconciler) Reconcile(ctx context.Context, _ reconcile.Reques
498499
}
499500

500501
if len(gwcResource.Gateways) == 0 {
501-
r.log.Info("No gateways found for accepted gatewayClass")
502+
r.log.Info("No gateways found for accepted gatewayClass", "gatewayClass", managedGC.Name)
502503

503504
// If needed, remove the finalizer from the accepted GatewayClass.
504505
if err := r.removeFinalizer(ctx, managedGC); err != nil {
505506
if isTransientError(err) {
506507
r.log.Error(err, "transient error removing finalizer from gatewayClass", "gatewayClass", managedGC.Name)
507508
return reconcile.Result{}, err
508509
}
509-
r.log.Error(err, fmt.Sprintf("failed to remove finalizer from gatewayClass %s",
510-
managedGC.Name))
510+
r.log.Error(err, "failed to remove finalizer from gatewayClass", "gatewayClass", managedGC.Name)
511511
}
512512
} else {
513513
// finalize the accepted GatewayClass.
@@ -516,8 +516,7 @@ func (r *gatewayAPIReconciler) Reconcile(ctx context.Context, _ reconcile.Reques
516516
r.log.Error(err, "transient error adding finalizer to gatewayClass", "gatewayClass", managedGC.Name)
517517
return reconcile.Result{}, err
518518
}
519-
r.log.Error(err, fmt.Sprintf("failed adding finalizer to gatewayClass %s",
520-
managedGC.Name))
519+
r.log.Error(err, "failed adding finalizer to gatewayClass", "gatewayClass", managedGC.Name)
521520
}
522521
}
523522
}

0 commit comments

Comments
 (0)