Skip to content

Conversation

@jukie
Copy link
Contributor

@jukie jukie commented Nov 4, 2025

What this PR does / why we need it:

  • Adds a more enhanced readiness check vs a healthz ping so that caches are synced before marking controller pods as ready
  • Fixes a bug when setting up controller where leader election was disabled
  • Enables controller warmup to allow non-leaders to pre-populate caches and keep them updated

Which issue(s) this PR fixes:

Fixes #7115

Release Notes: Yes

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.35%. Comparing base (84672ca) to head (242815e).

Files with missing lines Patch % Lines
internal/provider/kubernetes/kubernetes.go 41.66% 5 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (41.66%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7430      +/-   ##
==========================================
+ Coverage   72.31%   72.35%   +0.04%     
==========================================
  Files         231      231              
  Lines       34041    34051      +10     
==========================================
+ Hits        24617    24639      +22     
+ Misses       7645     7636       -9     
+ Partials     1779     1776       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jukie jukie marked this pull request as ready for review November 4, 2025 17:38
@jukie jukie requested a review from a team as a code owner November 4, 2025 17:38
@jukie jukie requested a review from a team November 4, 2025 17:40
@arkodg
Copy link
Contributor

arkodg commented Nov 4, 2025

hey can we get more info from the users to confirm this is seen during EG restarts, and for a short duration, then this fix would make sense

@jukie jukie force-pushed the readiness-check-tweak branch from c282dc0 to 2b51baa Compare November 4, 2025 22:28
@jukie jukie changed the title fix: wait for cache sync before marking controller pods ready fix: controller leader-election bug and cache-sync readiness Nov 4, 2025
@jukie jukie force-pushed the readiness-check-tweak branch from 2b51baa to 242815e Compare November 4, 2025 22:41
@jukie jukie marked this pull request as draft November 13, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent Envoy Gateway replica state

2 participants