feat: default remove accept encoding header

[buroa]

Continuation of #7406

This removes the accept-encoding header from each route if a compressor is present.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.32%. Comparing base (6a99849) to head (e136c11).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7562      +/-   ##
==========================================
- Coverage   72.33%   72.32%   -0.02%     
==========================================
  Files         232      232              
  Lines       34109    34116       +7     
==========================================
+ Hits        24674    24675       +1     
- Misses       7664     7668       +4     
- Partials     1771     1773       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[buroa]

/retest

[buroa]

/retest

[arkodg]

rethinking this one, shouldnt this be enabled by default ?
what do HAProxy, NGINX and others do ?

[buroa]

rethinking this one, shouldnt this be enabled by default ?

what do HAProxy, NGINX and others do ?

They pass it directly to the backend, this is not defaulted anywhere.

Do we want to default it? That would make it opinionated, but I think if compression is enabled at the Envoy level, we should.

[buroa]

@arkodg I just made this removeAcceptEncodingHeader default.

[arkodg]

why aren't we using the setting from the filter

[buroa]

It doesn't work correctly, at all. If I append apply the removeAcceptEncodingHeader on every compressor (no matter if its on the HCM one or the route overrides), it stops compression all together. If I apply it on one, it works, but it will only remove that header if that compression is picked.

[buroa]

I filed this in the meantime: envoyproxy/envoy#42160

[arkodg]

thanks, lets wait for the outcome of this before pushing code that needs to be updated again