Skip to content

chore: fix flaky weight test #7574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
+3 −3
Merged

chore: fix flaky weight test #7574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/e2e/testdata/weighted-backend-mixed-valid-and-invalid.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
backendRefs:
- name: infra-backend-v1
port: 8080
weight: 80
weight: 9
- name: infra-backend-not-existing
port: 8080
weight: 20
weight: 1
2 changes: 1 addition & 1 deletion test/e2e/tests/weighted_backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func testMixedValidAndInvalid(t *testing.T, suite *suite.ConformanceTestSuite) {
}
}

if !AlmostEquals(successCount, 40, 5) { // The weight of valid backend is 80%, so the expected success count is 50*80%=40
if !AlmostEquals(successCount, sendRequests*.9, 3) { // The weight of valid backend is 90%
t.Errorf("The actual success count is not within the expected range, success %d", successCount)
}
}