Skip to content

Conversation

@codefromthecrypt
Copy link
Contributor

What type of PR is this?
feat(telemetry): add new feature

What this PR does / why we need it:
Adds reportCountersAsDeltas and reportHistogramsAsDeltas fields to OpenTelemetry metric sink configuration for backends that require delta temporality.

Elastic OTLP endpoints require delta temporality for histograms - cumulative histograms are dropped:
https://www.elastic.co/docs/reference/opentelemetry/compatibility/limitations

The EDOT (Elastic Distribution of OpenTelemetry) SDKs default to delta temporality for this reason.

Release Notes: Yes

Example:

spec:
  telemetry:
    metrics:
      sinks:
        - type: OpenTelemetry
          openTelemetry:
            host: otel-collector.example.com
            port: 4317
            reportHistogramsAsDeltas: true
            reportCountersAsDeltas: true

@codefromthecrypt codefromthecrypt requested a review from a team as a code owner December 8, 2025 09:43
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.31%. Comparing base (b9123a8) to head (963f476).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7697      +/-   ##
==========================================
+ Coverage   72.28%   72.31%   +0.02%     
==========================================
  Files         234      234              
  Lines       34480    34482       +2     
==========================================
+ Hits        24924    24934      +10     
+ Misses       7767     7760       -7     
+ Partials     1789     1788       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Adds `reportCountersAsDeltas` and `reportHistogramsAsDeltas` fields
to OpenTelemetry metric sink configuration.

Required for backends like Elastic that drop cumulative histograms:
https://www.elastic.co/docs/reference/opentelemetry/compatibility/limitations

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt codefromthecrypt force-pushed the feat/otel-metrics-delta-temporality branch from e0541d6 to 963f476 Compare December 10, 2025 03:42
@codefromthecrypt
Copy link
Contributor Author

rebased.. hope for merge on this as it helps me undraft #7674 (as this makes otel-tui example readable on metrics)

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg merged commit 0c430c6 into envoyproxy:main Dec 10, 2025
52 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants