feat: support direct response limit greater than 4096 #7711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7711 +/- ##
==========================================
+ Coverage 72.34% 72.40% +0.06%
==========================================
Files 234 234
Lines 34542 34537 -5
==========================================
+ Hits 24988 25007 +19
+ Misses 7762 7744 -18
+ Partials 1792 1786 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cnvergence
previously approved these changes
Dec 10, 2025
cnvergence
reviewed
Dec 10, 2025
arkodg
reviewed
Dec 11, 2025
api/v1alpha1/shared_types.go
Outdated
| // If not specified the default is 4096. | ||
| // | ||
| // +optional | ||
| MaxSize *int `json:"maxSize,omitempty"` |
Contributor
There was a problem hiding this comment.
can we solve this w/o an API, based on input length ?
Member
Author
There was a problem hiding this comment.
that would be dangrous when some referenced a wrong secret by accident.
Contributor
There was a problem hiding this comment.
max size of a Secret or ConfigMap is 1MB
zirain
force-pushed
the
direct-response-body-size
branch
from
33a384f to
33455b5
Compare
zirain
changed the title
zirain
force-pushed
the
direct-response-body-size
branch
from
33455b5 to
b5a4e78
Compare
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
zirain
force-pushed
the
direct-response-body-size
branch
from
622d768 to
1d127d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5717