Skip to content

Conversation

@kkk777-7
Copy link
Member

What this PR does / why we need it:
Fixed that observedGeneration is missing from the EnvoyPatchPolicy status condition.
Introduce new field in IR to set observedGeneration.

Which issue(s) this PR fixes:

Fixes #7713

Release Notes: Yes

@kkk777-7 kkk777-7 requested a review from a team as a code owner December 10, 2025 16:09
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.29%. Comparing base (b9123a8) to head (661d494).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7715   +/-   ##
=======================================
  Coverage   72.28%   72.29%           
=======================================
  Files         234      234           
  Lines       34480    34481    +1     
=======================================
+ Hits        24924    24928    +4     
+ Misses       7767     7764    -3     
  Partials     1789     1789           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

message: Patches have been successfully applied.
reason: Programmed
status: "True"
message: A patch operation must specify a path or jsonPath.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the xDS translate output message are likely due to modifying the processing order in translator_test.go to reflect the translation results in the policy status.

In the current code on the main branch, the test case for errMsg returns early.
https://github.com/envoyproxy/gateway/blob/main/internal/xds/translator/translator_test.go#L183-L191
Therefore, I assume that when the policy message was updated, the changes were not reflected in the test output.

Signed-off-by: kkk777-7 <[email protected]>
@kkk777-7
Copy link
Member Author

/retest

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@zirain
Copy link
Member

zirain commented Dec 12, 2025

/retest

@kkk777-7 kkk777-7 merged commit 1ce65fc into envoyproxy:main Dec 13, 2025
73 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set observedGeneration in EnvoyPatchPolicy

3 participants