-
Notifications
You must be signed in to change notification settings - Fork 608
fix: set observedGeneration in envoy patch policy #7715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: kkk777-7 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7715 +/- ##
=======================================
Coverage 72.28% 72.29%
=======================================
Files 234 234
Lines 34480 34481 +1
=======================================
+ Hits 24924 24928 +4
+ Misses 7767 7764 -3
Partials 1789 1789 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| message: Patches have been successfully applied. | ||
| reason: Programmed | ||
| status: "True" | ||
| message: A patch operation must specify a path or jsonPath. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the xDS translate output message are likely due to modifying the processing order in translator_test.go to reflect the translation results in the policy status.
In the current code on the main branch, the test case for errMsg returns early.
https://github.com/envoyproxy/gateway/blob/main/internal/xds/translator/translator_test.go#L183-L191
Therefore, I assume that when the policy message was updated, the changes were not reflected in the test output.
Signed-off-by: kkk777-7 <[email protected]>
e99a920 to
661d494
Compare
|
/retest |
arkodg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
|
/retest |
What this PR does / why we need it:
Fixed that observedGeneration is missing from the EnvoyPatchPolicy status condition.
Introduce new field in IR to set observedGeneration.
Which issue(s) this PR fixes:
Fixes #7713
Release Notes: Yes