Add tests back #143
Merged
Add tests back #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eapolinario <[email protected]>
jyotimahapatra
approved these changes
Sep 12, 2020
samrabelachew
pushed a commit
to samrabelachew/xds-relay
that referenced
this pull request
Sep 21, 2020
Signed-off-by: eapolinario <[email protected]> Signed-off-by: Samra Belachew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #137 (comment), these tests were removed by mistake with the exception of the last one,
non matching field type, since by construction we cannot have an invalid field type. This PR adds them back.Signed-off-by: eapolinario [email protected]