Node metadata matcher #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
…neration Signed-off-by: eapolinario <[email protected]>
Signed-off-by: eapolinario <[email protected]>
Signed-off-by: Jyoti Mahapatra <[email protected]>
jyotimahapatra
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a matcher for node metadata fields. This is for #125.
Similarly to #137, we encode the node metadata information required in the aggregation rules in a pair of protos: (1)
NodeMetadataMatch, and (2)NodeMetadataAction, the former related to the matching process, whereas the latter has to do with the formation of the fragment.Envoy's node metadata is an opaque struct of type google.protobuf.Struct, which basically represents a dictionary of strings to Value.
This PR adds support for 3 of the 6 values:
string,bool, and a nested struct ofValue. The support for these other types is going to be added in separate PRs.