Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: #3923 - The scale of structures in "Select Attachment Points" Modal is too big #4059

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Macro: #3923 - The scale of structures in "Select Attachment Points" Modal is too big #4059

wants to merge 3 commits into from

Conversation

StarlaStarla
Copy link
Contributor

@StarlaStarla StarlaStarla commented Feb 8, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@StarlaStarla StarlaStarla linked an issue Feb 8, 2024 that may be closed by this pull request
Macro: The scale of structures in "Select Attachment Points" Modal is too big #3923
Open
rrodionov91
rrodionov91 requested changes Feb 8, 2024
View reviewed changes
packages/ketcher-core/src/application/render/renderStruct.ts Outdated
@@ -59,6 +59,9 @@ export class RenderStruct {
el: HTMLElement | null,
struct: Struct | null,
options: any = {},
originalStruct: Struct,
update = false,
monomerConnectionMode = false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose to rename it to something more common, like needRescale or somethingLike that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrodionov91 rrodionov91 rrodionov91 requested changes

@ilya-asiyuk-epam ilya-asiyuk-epam ilya-asiyuk-epam approved these changes

@AlexeyGirin AlexeyGirin Awaiting requested review from AlexeyGirin

@chgayane chgayane Awaiting requested review from chgayane

Requested changes must be addressed to merge this pull request.

Assignees

@StarlaStarla StarlaStarla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macro: The scale of structures in "Select Attachment Points" Modal is too big
3 participants
@StarlaStarla @rrodionov91 @ilya-asiyuk-epam