Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Communication Guidelines #710

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Open Communication Guidelines #710

merged 2 commits into from
Apr 18, 2024

Conversation

xentenza
Copy link
Collaborator

  • added Open Communication Guidelines to the news footer
  • corrected copyright date

- added Open Communication Guidelines to the news footer
- corrected copyright date
Copy link

github-actions bot commented Mar 26, 2024

Unit Test Results

    1 files      1 suites   0s ⏱️
268 tests 266 ✔️ 0 💤 0  2 🔥
268 runs  264 ✔️ 0 💤 2  2 🔥

For more details on these errors, see this check.

Results for commit ccdab5b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 26, 2024

🔎 Download the Backstop report for this pull request (link valid for 90 days):

Copy link
Member

@williambelle williambelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour éviter la duplication du template footer-legal-news.twig et footer-light-news.twig, je crois que c'est mieux avec un if dans le template footer-legal.twig. Par exemple :

{% if isNews %}
  <a href="https://go.epfl.ch/charte">Charte</a>
{% endif %}

C'est normal qu'on part sur epfl-mediacom.notion.site ? (au lieu de epfl.ch)
Et pas de traduction ?

- first PR revocated (too many files)
- introduction of conditions
- corrected footer page/news-detail
@xentenza
Copy link
Collaborator Author

xentenza commented Mar 27, 2024

Pour éviter la duplication du template footer-legal-news.twig et footer-light-news.twig, je crois que c'est mieux avec un if dans le template footer-legal.twig.

Excellente idée, Voilà qui est fait

C'est normal qu'on part sur epfl-mediacom.notion.site ? (au lieu de epfl.ch) Et pas de traduction ?

Oui, car le projet est encore en cours de traduction. Mise en ligne sur le site de l'EPFL le 19 avril 2024. Je te tiens au courant avant.

@xentenza
Copy link
Collaborator Author

@williambelle Les pages derrière les go sont traduites. Je n'ai plus qu'à les inclure dans le menu du site ;-)

@williambelle williambelle merged commit d8a1207 into dev Apr 18, 2024
4 checks passed
@williambelle williambelle deleted the styleguide/news-footer-ocg branch April 18, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants