[feature] Move menu-api in wp-ops's docker folder #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponsfrilus
force-pushed
the
feature/move-menu-api
branch
from
89a3c5c
to
5acc86d
Compare
rosamaggi
requested changes
Sep 24, 2024
| @@ -88,4 +88,7 @@ services: | |||
|
|
|||
| menu-api: | |||
| container_name: menu-api | |||
There was a problem hiding this comment.
to make the theme works correctly, you should call the container_name: menu-api-siblings as it's the name used in the breadcrumb.php file
docker-compose.yml
Outdated
| build: wp-ops/docker/menu-api | ||
| volumes: | ||
| - ./wp-ops/docker/menu-api/menu-api-config.yaml:/config/menu-api-config.yaml | ||
| - ./wp-ops/docker/menu-api/data:/data |
There was a problem hiding this comment.
I didn't give you the right config for the volume: the folder in the container is /app/data (in the configmap file the folder is "./data")
domq
force-pushed
the
feature/move-menu-api
branch
from
54bb94b
to
12c1e50
Compare
This also fix the "menu-api" not found on bare install
ponsfrilus
force-pushed
the
feature/move-menu-api
branch
from
12c1e50
to
522a50a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fix the "menu-api" not found on bare install.
It comes with a
make menu-apithat should handle thegit checkoutof the menu-api folder inwp-ops/docker/menu-api. Then you can run amake upas usual.