Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] new option to display a "subscribe to channel" link #382

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ponsfrilus
Copy link
Member

This feature add a new option that user can use to display a subscribe to channel button. It head to the channel subscription page, such as https://news.epfl.ch/subscription/news/subscribe/1.

* Button "Display the subscribe link" added
* Functions (`epfl_news_*`) signature for template updated
* Translations regenerated
* Bump to version 2.27.0
@ponsfrilus ponsfrilus added the enhancement New feature or request label Aug 16, 2023
@ponsfrilus ponsfrilus self-assigned this Aug 16, 2023
@ponsfrilus ponsfrilus marked this pull request as draft August 16, 2023 18:33
@ponsfrilus ponsfrilus marked this pull request as ready for review August 16, 2023 18:35
Copy link
Member

@jdelasoie jdelasoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, but as discussed by the committee last year, it is not something wanted.

@ponsfrilus
Copy link
Member Author

Thanks for the change, but as discussed by the committee last year, it is not something wanted.

Very sad that such a "committee" didn't even test this feature that promotes its own tool (newsletter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants