PWA more offline availability #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixrindt
added
[C] enhancement
felixrindt
commented
Jul 14, 2023
felixrindt
force-pushed
the
pwa-improvements
branch
from
3dcd1f7
to
8edc55f
Compare
felixrindt
force-pushed
the
pwa-improvements
branch
from
ecb1aa9
to
8078808
Compare
felixrindt
commented
Jul 14, 2023
felixrindt
commented
Jul 15, 2023
felixrindt
commented
Jul 15, 2023
felixrindt
commented
Jul 15, 2023
jeriox
approved these changes
Jul 16, 2023
|
When trying this with the offline simulator in Chrome Desktop, the CSS of the offline page is not rendered. Service worker has been freshly installed. Also on the cached pages there is no offline banner visible |
felixrindt
force-pushed
the
pwa-improvements
branch
from
170b599
to
f7e6f5c
Compare
felixrindt
commented
Jul 16, 2023
felixrindt
force-pushed
the
pwa-improvements
branch
from
29e0464
to
5bd27af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the PWA views to class based views and adds a few more fields. Then there are some random fixes and touchups. Biggest change (and the most debatable) is the new serviceworker that caches sites you visit on the go.