Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA Fixups #1002

Merged
merged 2 commits into from
Jul 17, 2023
Merged

PWA Fixups #1002

merged 2 commits into from
Jul 17, 2023

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Jul 16, 2023 •
edited
Loading

  • instead of returning the /offline/ template for cacheThenNetwork-Requests, just fail.
  • also delete the caches going by the old cache naming scheme.

@coveralls
Copy link

coveralls commented Jul 16, 2023 •
edited
Loading

Coverage Status

coverage: 88.459% (+0.002%) from 88.457% when pulling 9ecec89 on pwa-fixups into b2b2ace on main.

@felixrindt felixrindt closed this Jul 16, 2023
@felixrindt felixrindt reopened this Jul 16, 2023
@felixrindt felixrindt marked this pull request as ready for review July 17, 2023 13:59
@felixrindt felixrindt added the [C] bug Something isn't working label Jul 17, 2023
@felixrindt felixrindt merged commit 0c7c4c7 into main Jul 17, 2023
31 checks passed
@felixrindt felixrindt deleted the pwa-fixups branch July 17, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox approved these changes

Assignees
No one assigned
Labels
[C] bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixrindt @coveralls @jeriox