Email attachments #1024
Merged
Email attachments #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixrindt
added
the
[C] refactoring
felixrindt
force-pushed
the
email-attachments
branch
from
b83507e
to
b121283
Compare
jeriox
approved these changes
Aug 14, 2023
felixrindt
force-pushed
the
email-attachments
branch
from
8214e17
to
a47757d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some slight refactoring for the email sending infrastructure to allow for templates and passing in basic body text.
Future txt email templates should be based on
base.txt(though it doesn't do much).I also added an
organization_nametag just like #972 . Will need to sort that once one of the PRs gets merged.Todo:
absolute_urlfunction to wrap getting the site url and joining it with the location.