-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid deleting the last staff user #1036
Conversation
Changes unknown when pulling 138998c on fix-cannot-delete-last-staff-user into ** on main**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to implement similar checks for at least one group with the "can manage ephios instance" permission? AFAIS you could loose that permission and even staff users wouldn't be able to recover it
I think that's a very good idea. UX wise we could also just disable the delete button instead of showing the error only after people hit delete. What do you think? |
yes that would be a bit smoother, but I could also live with the version you implemented here |
636d5fd
to
8817563
Compare
9fdc1b8
to
d630f93
Compare
d630f93
to
138998c
Compare
depends on #1037 so rebase main onto that first