Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker deployment #1064

Merged
merged 14 commits into from
Sep 14, 2023
Merged

Add docker deployment #1064

merged 14 commits into from
Sep 14, 2023

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Sep 12, 2023 •
edited
Loading

I added a Dockerfile and I'm trying to figure out how to deploy it using docker-compose.
I also changed the settings.py to reduce the amount of variables that need to be configured, streamlining the deployment for manual deployments as well.

TODO

  • fix CSRF_TRUSED_ORIGINS
  • update manual deployment documentation for new env variables
  • write docker documentation
  • update our deployments, tests and docs to use the new variables
  • container health check
  • resolve warnings in tests
  • github workflow
  • integrate health checks

@coveralls
Copy link

coveralls commented Sep 12, 2023 •
edited
Loading

Coverage Status

coverage: 88.635% (-0.6%) from 89.228% when pulling 4c10147 on dockerfile into c3c9305 on main.

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 12, 2023
View reviewed changes
ephios/settings.py Fixed Show resolved Hide resolved
jeriox
jeriox reviewed Sep 12, 2023
View reviewed changes
ephios/settings.py Outdated Show resolved Hide resolved
jeriox
jeriox reviewed Sep 12, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
deployment/docker-compose/docker-compose.yml Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 13, 2023
View reviewed changes
ephios/extra/secrets.py Dismissed Show dismissed Hide dismissed
@felixrindt felixrindt marked this pull request as ready for review September 13, 2023 13:00
@felixrindt felixrindt force-pushed the dockerfile branch 4 times, most recently from c314c73 to 9601db4 Compare September 13, 2023 13:19
@felixrindt felixrindt force-pushed the dockerfile branch 5 times, most recently from 3476ce5 to b861866 Compare September 13, 2023 14:29
felixrindt
felixrindt commented Sep 13, 2023
View reviewed changes
docs/admin/deployment/docker/index.rst Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Show resolved Hide resolved
felixrindt
felixrindt commented Sep 13, 2023
View reviewed changes
ephios/settings.py Outdated Show resolved Hide resolved
felixrindt
felixrindt commented Sep 13, 2023
View reviewed changes
ephios/settings.py Outdated Show resolved Hide resolved
jeriox
jeriox approved these changes Sep 14, 2023
View reviewed changes
deployment/compose/docker-compose.yaml Outdated Show resolved Hide resolved
@felixrindt felixrindt force-pushed the dockerfile branch 5 times, most recently from 5d90d7a to 1c54298 Compare September 14, 2023 14:25
@felixrindt felixrindt enabled auto-merge (rebase) September 14, 2023 14:32
@felixrindt felixrindt merged commit 4253ca2 into main Sep 14, 2023
18 checks passed
@felixrindt felixrindt deleted the dockerfile branch September 14, 2023 14:37
@felixrindt felixrindt added the [C] infrastructure Changes to CI and deployment label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox approved these changes

Assignees
No one assigned
Labels
[C] infrastructure Changes to CI and deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixrindt @coveralls @jeriox