Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complex shift structure #1343

Merged
merged 17 commits into from
Sep 19, 2024
Merged

Add complex shift structure #1343

merged 17 commits into from
Sep 19, 2024

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Aug 26, 2024

  • tests
  • pdf export
  • explanatory documentation
  • API views
  • test whether the has_free check is correct with semantically different units requiring the same qualifications
  • Show label name in selects
  • matching: prefer confirmed participants

@coveralls
Copy link

coveralls commented Aug 26, 2024

Coverage Status

coverage: 85.678% (-1.8%) from 87.448%
when pulling 2b7867b on complex-structure
into 41ce283 on main.

@felixrindt felixrindt force-pushed the complex-structure branch 2 times, most recently from 9ec65ee to 4f4900b Compare September 10, 2024 19:41
@felixrindt felixrindt marked this pull request as ready for review September 10, 2024 20:24
@felixrindt
Copy link
Member Author

This is a "bug" I think we should address if we ever refactor the matching service:

Ronny is designated for the upper block, so that block should be shown as full (as no one else would be able to get in there).
Because I can't know about the designation when scoring the other position with Ronny (because that info is only available on the position he's designated for) the algorithm considers the other position valid for him too and thus sees it as acceptable putting him there to put another person on the upper block.

image

Fixing this would require even more spaghetti-wrangling the matching code - or a whole rewrite. I think waiting to refactor the whole thing is a smart move, as this is just a minor bug with it.

You could of course also argue this is intended behavior, as for instant signup, as designation is not visible in the overview, and disposition doesn't have to be final etc.

@jeriox jeriox force-pushed the complex-structure branch 2 times, most recently from d10fb1f to 2b7867b Compare September 19, 2024 15:23
@jeriox jeriox enabled auto-merge (rebase) September 19, 2024 15:26
@jeriox jeriox linked an issue Sep 19, 2024 that may be closed by this pull request
@jeriox jeriox merged commit b61e68f into main Sep 19, 2024
14 of 15 checks passed
@jeriox jeriox deleted the complex-structure branch September 19, 2024 15:29
@jeriox jeriox added the [C] feature New feature or request label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New signup method "complex requirements"
3 participants