add vue recurrence picker #1348
Conversation
|
First draft implementation: |
jeriox
force-pushed
the
new-recurrence
branch
2 times, most recently
from
4110a43
to
26d0b04
Compare
jeriox
force-pushed
the
new-recurrence
branch
from
aa15014
to
a63aaec
Compare
| event.target.submit(); | ||
| } | ||
|
|
||
| function isRuleValid(rule) { |
There was a problem hiding this comment.
this is stricter than the RFC, but I thought it would be suitable for us (e.g. end of recurrence mandatory, days of weeks/month need to be specified instead of being derived from DTSTART)
|
The layout is not mobile-optimized. And it might make sense to not use two columns on mobile.
|
jeriox
force-pushed
the
new-recurrence
branch
from
a63aaec
to
52c935e
Compare
|
I don't know what went wrong here, but the calculated dates are incorrect (should be 2024-09-16 and 2024-09-23).
However, when clicking copy, the events will be copied to the right dates. |
what timezone is your browser in? I fought a lot with that, but on my machine it was correct in the end when I was in Europe/Berlin as well. |
Europe/Berlin (according to Same behavior across Firefox (130.0), Firefox Developer Edition (130.0b9) and Chromium (128.0.6613.137) on the same machine as well as Firefox for Android (130.0). All browsers have timezone Europe/Berlin which is also set on the respective OS. |
|
I'm not familiar with the recurrence spec, but my naive expectation with a recurrence like "weekly, Mondays and Tuesdays, for 2 occurrences" would be that there are 4 copies in total (two times Monday and Tuesday), but there are only two total copies (one time Monday and Tuesday). The behavior is consistent across the preview in the frontend and the actual copies created in the backend, so I think it is correct behavior, but it might be worth explaining, for example with an ℹ️-icon after "occurrences" that shows a tooltip explaining the interpretation of the number (overall number of copies, not number of weeks). |
|
Maybe related to the timezones: By chance, I've noticed that the following pattern causes an error "Invalid recurrence rule: unsupported RDATE parm: TZID=EUROPE/BERLIN" reproducibly:
Tested in Firefox Developer Edition and Chromium, but the error seems to come from the backend, as it is rendered as |
| function formatDate(date_obj, sep = "-") { | ||
| let month = date_obj.getMonth() + 1; | ||
| let day = date_obj.getDate() + 1; | ||
| return date_obj.getFullYear() + sep + (month < 10 ? "0" : "") + month + sep + (day < 10 ? "0" : "") + day | ||
| } |
There was a problem hiding this comment.
There must not be a + 1 for the day/date. Only the month is 0-based. This should also fix #1348 (comment)
There was a problem hiding this comment.
done, could you pls check again?
good catch, forgot to mention that in the PR. this property is currently not supported in the library, I opened a PR to fix this |
closes #195 closes #958
ToDo