Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete user webpush subscription if delivery fails #1364

Merged
merged 1 commit into from
Oct 2, 2024
Merged

delete user webpush subscription if delivery fails #1364

merged 1 commit into from
Oct 2, 2024

Conversation

jeriox
Copy link
Contributor

@jeriox jeriox commented Sep 28, 2024

closes #1198

@coveralls
Copy link

Coverage Status

coverage: 85.661% (-0.009%) from 85.67%
when pulling 250b754 on webpush-delete-subscription
into fa2e7d9 on main.

felixrindt
felixrindt approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@felixrindt felixrindt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems more excessive than necessary. But I guess we don't have the info which device failed?!

@jeriox
Copy link
Contributor Author

jeriox commented Sep 29, 2024

Seems more excessive than necessary. But I guess we don't have the info which device failed?!

exactly. the library catches expired subscriptions and only deletes them for a single device, but that info does not get propagated

@jeriox jeriox merged commit 721a1ee into main Oct 2, 2024
15 checks passed
@jeriox jeriox deleted the webpush-delete-subscription branch October 2, 2024 18:14
@jeriox jeriox added the [C] bug Something isn't working label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrindt felixrindt felixrindt approved these changes

Assignees
No one assigned
Labels
[C] bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove push subscription if delivery fails
3 participants
@jeriox @coveralls @felixrindt