Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for events to be cancelled #883

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow for events to be cancelled #883

wants to merge 1 commit into from

Conversation

jeriox
Copy link
Contributor

@jeriox jeriox commented Feb 3, 2023

closes #373

@jeriox
Copy link
Contributor Author

jeriox commented Feb 3, 2023

@felixrindt I'm not sure how we want to proceed with a delete button for the event. Should we always offer both options? Or only allow the event to be deleted without being cancelled first when there are no participations?

@coveralls
Copy link

Coverage Status

Coverage: 87.697% (-0.3%) from 87.95% when pulling dd99b80 on event-cancellation into 8389f0f on main.

@felixrindt
Copy link
Member

@felixrindt I'm not sure how we want to proceed with a delete button for the event. Should we always offer both options? Or only allow the event to be deleted without being cancelled first when there are no participations?

I think we should allow both, that is:

  • deleting an event entirely, even if it has participations without sending an email
  • the more graceful approach introduced in this PR.

Maybe we can join the two together into one form. Also, what about the bulk delete action? Should it work on events with participations?

@jeriox
Copy link
Contributor Author

jeriox commented Feb 6, 2023

@felixrindt I'm not sure how we want to proceed with a delete button for the event. Should we always offer both options? Or only allow the event to be deleted without being cancelled first when there are no participations?

I think we should allow both, that is:

* deleting an event entirely, even if it has participations without sending an email

* the more graceful approach introduced in this PR.

Maybe we can join the two together into one form. Also, what about the bulk delete action? Should it work on events with participations?

I like that idea. The user could then only have one button with "delete event" and can check a checkbox in the delete view with "notify users about the cancellation". if checked, the textarea for the message appears.

I don't see a reason why the bulk action shouldn't work?

@felixrindt felixrindt added the [C] feature New feature or request label Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel event
3 participants