Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add File Logging #976

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Add File Logging #976

merged 2 commits into from
Aug 3, 2023

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Jun 16, 2023 •
edited
Loading

  • set root log level for console logging to WARNING
  • create file logging with INFO level (incl rotation)

closes #349

@felixrindt felixrindt requested a review from jeriox June 16, 2023 13:20
@felixrindt felixrindt self-assigned this Jun 16, 2023
@coveralls
Copy link

coveralls commented Jun 16, 2023 •
edited
Loading

Coverage Status

coverage: 88.439% (-0.007%) from 88.446% when pulling ae1f621 on default_logging_level into 7399a33 on main.

@felixrindt felixrindt changed the title set default log level to INFO Add File Logging Jun 16, 2023
@felixrindt felixrindt added the [C] infrastructure Changes to CI and deployment label Jun 24, 2023
@felixrindt felixrindt marked this pull request as draft June 24, 2023 00:04
@felixrindt felixrindt marked this pull request as ready for review August 2, 2023 22:07
@felixrindt felixrindt requested a review from jeriox August 2, 2023 22:07
@felixrindt felixrindt merged commit 2cd81d5 into main Aug 3, 2023
16 checks passed
@felixrindt felixrindt deleted the default_logging_level branch August 3, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox Awaiting requested review from jeriox

Assignees

@felixrindt felixrindt

Labels
[C] infrastructure Changes to CI and deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proper logging setup
3 participants
@felixrindt @coveralls @jeriox