Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms Template/JS Refactoring #998

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Forms Template/JS Refactoring #998

merged 3 commits into from
Jul 13, 2023

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Jul 11, 2023

I intend to merge this with rebase (no squash).

  • refactor PluginForms to use form templates instead of FormHelper
  • update jQuery to 3.7.0
  • reduce flicker in formset handler by
    • hiding the new form before it is added to the dom when using animation, therefore no flicker when clicking the add button
    • creating a new event type to handleForms before the slideDown animation. Before, the animation would compute before handleForms was called and therefore use the wrong html (e.g. the vanilla select-multiple instead of select2 which is smaller) leading to jumps at the end of the animation

@felixrindt felixrindt requested a review from jeriox July 11, 2023 16:03
@felixrindt felixrindt added the [C] refactoring refactors code without changing functionality label Jul 11, 2023
@coveralls
Copy link

coveralls commented Jul 11, 2023

Coverage Status

coverage: 88.077% (-0.2%) from 88.251% when pulling 4b9f152 on refactor-plugin-forms into e8802ee on main.

@felixrindt felixrindt changed the title refactor PluginForms to use form templates instead of FormHelper Forms Template/JS Refactoring Jul 12, 2023
@felixrindt felixrindt merged commit 01f46d1 into main Jul 13, 2023
16 checks passed
@felixrindt felixrindt deleted the refactor-plugin-forms branch July 13, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] refactoring refactors code without changing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants