Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-table): allow sorting-order to be null #4065

Merged

Conversation

joshLumpkin
Copy link
Contributor

closes #4063

Description

I added null as a prop option on the sortingOrder

Markup:

export const useSortableProps = {
  ...useThrottleProps,
  sortBy: { type: String as PropType<string | undefined> },
  columnSorted: { type: Object as PropType<any | undefined> },
  sortingOrder: { type: String as PropType<DataTableSortingOrder | null | undefined> },
}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem m0ksem merged commit 6e7a8de into epicmaxco:develop Dec 5, 2023
1 check passed
@m0ksem m0ksem changed the title Update useSortable.ts fix(data-table): allow sorting-order to be null Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VaDataTable: sortingOrder should allow null as prop type
2 participants