Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chromatic screenshots tests status #4481

Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix: chromatic screenshots tests status #4481

merged 2 commits into from
Feb 21, 2025

Conversation

TFX-98
Copy link
Collaborator

@TFX-98 TFX-98 commented Feb 20, 2025 •
edited
Loading

Description

  1. Closes Fix screenshot tests for VaDatePicker #4299:
    • Separate Default story;
    • Disable screenshots on some stories;
  2. Transferred currentMonthDayView in another story + added all types of checks;
  3. Added tests for Range story;
  4. Added autodocs tag;

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@TFX-98 TFX-98 requested a review from asvae February 20, 2025 09:00
@netlify Netlify
Copy link

netlify bot commented Feb 20, 2025 •
edited
Loading

❌ Deploy Preview for vuestic-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 3f96e1c
🔍 Latest deploy log https://app.netlify.com/sites/vuestic-docs/deploys/67b83ad8a5f9290008a809e1

@netlify Netlify
Copy link

netlify bot commented Feb 20, 2025 •
edited
Loading

✅ Deploy Preview for vuestic-storybook ready!

Name Link
🔨 Latest commit 3f96e1c
🔍 Latest deploy log https://app.netlify.com/sites/vuestic-storybook/deploys/67b83ad82342cc0008e62570
😎 Deploy Preview https://deploy-preview-4481--vuestic-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TFX-98 TFX-98 added tests Refers to testing storybook Relates to storybook labels Feb 20, 2025
@TFX-98 TFX-98 requested a review from m0ksem February 20, 2025 09:19
asvae
asvae reviewed Feb 20, 2025
View reviewed changes
packages/ui/src/components/va-date-picker/VaDatePicker.stories.ts Outdated
components: { VaDatePicker },
template: `
<VbDemo>
<VbCard title="statefull">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's split these into multiple stories.

asvae
asvae reviewed Feb 20, 2025
View reviewed changes
packages/ui/src/components/va-date-picker/VaDatePicker.stories.ts Outdated
</VbDemo>
`,
})
dynamicCurrentDate.parameters = { chromatic: { disableSnapshot: true } }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment why

asvae
asvae reviewed Feb 20, 2025
View reviewed changes
packages/ui/src/components/va-date-picker/VaDatePicker.stories.ts Outdated
export const dynamicCurrentDate: StoryFn = () => ({
components: { VaDatePicker },
template: `
<VbDemo>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is not needed

@TFX-98 TFX-98 force-pushed the fix/screenshot-tests branch from 74795cd to 3f96e1c Compare February 21, 2025 08:35
@TFX-98 TFX-98 requested a review from asvae February 21, 2025 08:36
asvae
asvae approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks much better

@asvae asvae merged commit 0620c72 into epicmaxco:develop Feb 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvae asvae asvae approved these changes

@m0ksem m0ksem Awaiting requested review from m0ksem

Assignees
No one assigned
Labels
storybook Relates to storybook tests Refers to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix screenshot tests for VaDatePicker
2 participants
@TFX-98 @asvae