Merged
Conversation
- enhance status and request type parsing logic - add handling to skip formatting when optional data missing - include checks for log message prefixes - add debug log statements (commented out) for easier tracing
- Increments the minor version to mark upcoming release - Prepares for integration of pending updates and fixes
- Document enhanced status and request parsing logic - Note handling for missing optional data to skip formatting - Mention checks for log message prefixes - Indicate addition of (commented out) debug log statements for tracing
- Change expected status from string to integer in test - Ensure correctness by matching expected data type
jonrandahl
requested review from
DanielCouzens,
bogdanadrianmarc and
joescottdave
|
|
||
| - Enhanced status and request type parsing logic | ||
| - Added handling to skip formatting when optional data missing | ||
| - Included checks for log message prefixes |
Contributor
There was a problem hiding this comment.
Should the change log have a link to a gh ticket or is there no project board for this work?
Contributor
Author
There was a problem hiding this comment.
Thanks @DanielCouzens -
Because this gem is used on multiple applications and this update, while initiated via the catalog lift & shift, is not specific to that app and will benefit all applications using the gem.
Once the updated gem has been published I will link to the ticket that prompted the updates in that repo.
Hope that makes sense!
bogdanadrianmarc
approved these changes
Sep 15, 2025
Collaborator
bogdanadrianmarc
left a comment
bogdanadrianmarc
left a comment
There was a problem hiding this comment.
Changes look good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the JSON Rails Logger gem, focusing on more robust parsing of status and request types, improved handling of optional data, and better traceability for debugging. The changes also update the gem version to 2.2.0.
Parsing and Data Handling Improvements
json_formatter.rb, including handling cases where log messages have prefixes and ensuring numeric status codes are parsed as integers.Debugging and Traceability
Version and Documentation Updates
version.rband documented the new features inCHANGELOG.md. [1] [2]Test Adjustments