Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we use an endpoint that requires auth when checking creds #357

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Ensure we use an endpoint that requires auth when checking creds #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/jetstream/authepinio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ func (a *epinioAuth) verifyLocalLoginCreds(username, password string) error {
}

// Make a request to the epinio endpoint that requires auth
credsUrl := fmt.Sprintf("%s/api/v1/info", epinioEndpoint.APIEndpoint.String())
credsUrl := fmt.Sprintf("%s/api/v1/me", epinioEndpoint.APIEndpoint.String())

req, err := http.NewRequest("GET", credsUrl, nil)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion backend/src/jetstream/plugins/epinio/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func (epinio *Epinio) Register(echoContext echo.Context) error {
func (epinio *Epinio) Validate(userGUID string, cnsiRecord interfaces.CNSIRecord, tokenRecord interfaces.TokenRecord) error {
// Validate is used to confirm the user's creds after the user connects
// For this flow we don't need to do this, it was done when the user logs in in authepinio
// (makes a request to `/api/v1/info`)
// (makes a request to `/api/v1/me`)
return nil
}

Expand Down
Loading