Implement Coinbase Advanced Pair Converter Plugin #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macanudo527
changed the title
macanudo527
force-pushed
the
pair_converters/implement_coinbase_advanced
branch
from
b3516fd to
666a713
Compare
orientalperil
suggested changes
Dec 13, 2024
macanudo527
force-pushed
the
pair_converters/implement_coinbase_advanced
branch
from
dff740f to
433902e
Compare
eprbell
requested changes
Jan 13, 2025
...settes/test_plugin_coinbase_advanced/TestHistoricCryptoPlugin.test_granularity_response.yaml
Outdated
Show resolved
Hide resolved
eprbell
requested changes
Jan 16, 2025
macanudo527
force-pushed
the
pair_converters/implement_coinbase_advanced
branch
from
9bc011e to
b5a50a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a replacement for the historic crypto pair converter plugin that is no longer available. I made use of the Coinbase Advanced API with help from a code sample provided by @orientalperil here
Testing
I have not tested this personally with the real Coinbase server. I'll try to work up a short test to see if calls work as expected.