Apply subtitle to book_title for book chapter items #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If subtitle defined when setting book title during chapter import then apply the subtitle to the book title rather than leave it to be applied to the chapter.
drn05r
approved these changes
Jan 28, 2025
drn05r
reviewed
Mar 6, 2025
There was a problem hiding this comment.
I am not sure if this would always be the correct behaviour, as it depends what the subtitle is. Currently, it looks like the DOI import plugin assumes the subtitle is the name of the chapter or section whereas the title is the name of the book. Therefore, the volume_title (ultimately the book title in an eprint record) is the main title, as it is assume this is just the name of the book and the title is the name of the book followed by the name of the chapter/section.
This seems to me generally the right thing to do. If you could provides some DOIs I could test with where this would not produce the correct import, then we can see if there is a way of catering for both scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Book subtitle is being included with the Chapter title in error.
If subtitle defined when setting book title during chapter import then apply the subtitle to the book title and clear it from the subtitle data field rather than leave it to be applied to the chapter.