Skip to content

Commit

Permalink
Don't panic when job submission fails (#30)
Browse files Browse the repository at this point in the history
* Don't panic when job submission fails, just log error

* Bump version 0.1.5 -> 0.1.6
  • Loading branch information
milesgranger authored Oct 29, 2019
1 parent 9cf9430 commit a67d85c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "gordo-controller"
version = "0.1.5"
version = "0.1.6"
authors = ["Miles Granger <[email protected]>"]
edition = "2018"

Expand Down
5 changes: 1 addition & 4 deletions src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,7 @@ fn start_gordo_deploy_job(

match jobs.create(&postparams, serialized_spec) {
Ok(job) => info!("Submitted job: {:?}", job.metadata.name),
Err(e) => {
error!("Failed to submit job with error: {:?}", e);
unimplemented!("Haven't implemented a way to deal with this, exiting."); // Kubernetes will restart us
}
Err(e) => error!("Failed to submit job with error: {:?}", e)
}

// Update the status of this job
Expand Down

0 comments on commit a67d85c

Please sign in to comment.