Instantiate Mock members by function #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sondreo
force-pushed
the
mock-step-fix
branch
from
44b72ff
to
74aae96
Compare
Format files Make MockStep methods static
sondreo
force-pushed
the
mock-step-fix
branch
from
74aae96
to
2c1903e
Compare
tsundvoll
requested changes
Feb 27, 2024
| return DriveToPose(pose=MockPose.default_pose) | ||
|
|
||
| @staticmethod | ||
| def take_image_in_coordinate_direction() -> TakeImage: |
There was a problem hiding this comment.
Suggested change
| def take_image_in_coordinate_direction() -> TakeImage: | |
| def get_dummy_take_image_step() -> TakeImage: |
There was a problem hiding this comment.
See below regarding naming. It is added as a separate issue.
| @@ -5,7 +5,10 @@ | |||
|
|
|||
|
|
|||
| class MockStep: | |||
There was a problem hiding this comment.
Suggested change
| class MockStep: | |
| class DummyStep: |
Also consider using the naming "Stub" or "Fake", both may be representative of what we try to accomplish here. Relevant article: https://jesusvalerareales.com/testing-with-test-doubles/
Also, does not need to be solved here, you can make an issue for it and suggest a renaming for all similar "Mocks" that should be called "Dummy", "Stub", or "Fake"
There was a problem hiding this comment.
Good idea, and great tip for a relevant resource. I will defer this to a separate issue, and have created one.
sondreo
changed the title
tsundvoll
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in state machine tests due to class instance member being mutated across different tests.
Resolves #516