Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distillation solver fix #1295

Merged
merged 4 commits into from
Mar 3, 2025
Merged

distillation solver fix #1295

merged 4 commits into from
Mar 3, 2025

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Mar 3, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 64.53488% with 61 lines in your changes missing coverage. Please review.

Project coverage is 41.82%. Comparing base (aa9ccd1) to head (77aeed7).

Files with missing lines Patch % Lines
...ess/equipment/distillation/DistillationColumn.java 64.66% 45 Missing and 8 partials ⚠️
...qsim/process/equipment/distillation/Condenser.java 63.63% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1295      +/-   ##
============================================
+ Coverage     41.77%   41.82%   +0.04%     
- Complexity     6194     6201       +7     
============================================
  Files           733      733              
  Lines         69803    69785      -18     
  Branches       8368     8357      -11     
============================================
+ Hits          29160    29186      +26     
+ Misses        38865    38819      -46     
- Partials       1778     1780       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol changed the title update distillation solved fix Mar 3, 2025
@EvenSol EvenSol changed the title distillation solved fix distillation solver fix Mar 3, 2025
@EvenSol EvenSol merged commit 010d6d8 into master Mar 3, 2025
12 checks passed
@EvenSol EvenSol deleted the fix-distillation-column branch March 3, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants