Revert numpy.i changes, pin swig<4.3.0 #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 743b2ce.
This version and the changes to numpy.i that come with it (pulled directly from the numpy repository) caused segfaults under certain circumstances in Python 3.8, in particular when in a context where pandas>2 is used. It's very difficult to understand the interactions causing these problems and the most prudent thing to do seems to be to wait until we deprecate support for Python 3.8 and then unpin swig.
jcrivenaes
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1275
We can unpin swig once we drop support for Python 3.8 and move forward with #1233