This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Remove incorrect code from contract details decoder#664
Closed
djkelleher wants to merge 1 commit intoerdewit:masterfrom
djkelleher:fix_contract_details_decoder
Closed
Remove incorrect code from contract details decoder#664djkelleher wants to merge 1 commit intoerdewit:masterfrom djkelleher:fix_contract_details_decoder
djkelleher wants to merge 1 commit intoerdewit:masterfrom
djkelleher:fix_contract_details_decoder
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem - The current contract details decoder contains a bit of code that should only be used in the bond contract details decoder.
Effect - The function first correctly assigns the timeZoneId, but then later in the function body overwrites it with the timezone TWS is set to use.
Solution - Delete the extra code.
For reference, here is the logic from the official API from Interactive Brokers: