[Redesign] Add type annotations to operator and component creator#278
Open
HivaMohammadzadeh1 wants to merge 3 commits intoerdos-project:redesignfrom
Open
[Redesign] Add type annotations to operator and component creator#278HivaMohammadzadeh1 wants to merge 3 commits intoerdos-project:redesignfrom
HivaMohammadzadeh1 wants to merge 3 commits intoerdos-project:redesignfrom
Conversation
pschafhalter
changed the title
pschafhalter
reviewed
Aug 2, 2022
Member
pschafhalter
left a comment
pschafhalter
left a comment
There was a problem hiding this comment.
Left some feedback. It might be a good idea to break this PR into smaller pieces.
Comment on lines
+443
to
+451
| def add_prediction(obstacles_tracking_stream: Stream[ObstaclesMessageTuple], | ||
| vehicle_id_stream: Stream[int], | ||
| release_sensor_stream: Stream[None], | ||
| point_cloud_stream: Stream[PointCloud], | ||
| lidar_setup: Stream[LidarSetup], | ||
| pose_stream: Optional[Stream[pylot.utils.Pose]] = None, | ||
| Camera_transform = None, | ||
| time_to_decision_stream: Optional[Stream[float]] = None | ||
| ) -> Tuple[Stream[prediction], Stream[int], Stream]: |
Member
There was a problem hiding this comment.
Could you make sure that the arguments remain in the same order as before?
Member
There was a problem hiding this comment.
Also, the return type should be Tuple[Stream[List[ObstaclePrediction]], Stream[SegmentedFrame], Stream[None]]
|
|
||
| def add_traffic_light_invasion_sensor(ground_vehicle_id_stream: Stream, | ||
| pose_stream: Stream) -> Stream: | ||
| pose_stream: Stream[pylot.utils.Pose]) -> Stream: |
Member
There was a problem hiding this comment.
Please add an annotation the returned stream with the message type.
| camera_setup, | ||
| name='center_track'): | ||
| def add_center_track_tracking(bgr_camera_stream: Stream[CameraFrame], | ||
| camera_setup: Stream[CameraSetup], |
Member
There was a problem hiding this comment.
Suggested change
| camera_setup: Stream[CameraSetup], | |
| camera_setup: CameraSetup, |
| global_trajectory_stream, | ||
| prediction_stream: Stream[prediction], | ||
| time_to_decision_stream: Optional[Stream[float]] = None, | ||
| pose_stream: Optional[Stream[pylot.utils.Pose]] = None) -> Stream: |
Member
There was a problem hiding this comment.
Please annotate the return type of the stream -- it should carry waypoints.
| from absl import flags | ||
|
|
||
| from erdos import Stream | ||
| from pylot import prediction |
Member
There was a problem hiding this comment.
Suggested change
| from pylot import prediction |
|
|
||
| import erdos | ||
| from erdos import Stream | ||
| from pylot import prediction |
Member
There was a problem hiding this comment.
Suggested change
| from pylot import prediction |
Comment on lines
+30
to
+34
|
|
||
| from pylot.loggers.pose_logger_operator import PoseLoggerOperator | ||
| from pylot.loggers.imu_logger_operator import IMULoggerOperator | ||
| from pylot.prediction import obstacle_prediction | ||
|
|
Member
There was a problem hiding this comment.
Why were these imports added?
|
|
||
| def add_linear_prediction(tracking_stream: Stream, | ||
| time_to_decision_stream: Stream) -> Stream: | ||
| time_to_decision_stream: Stream) -> Stream[prediction]: |
Member
There was a problem hiding this comment.
Suggested change
| time_to_decision_stream: Stream) -> Stream[prediction]: | |
| time_to_decision_stream: Stream[float]) -> Stream[List[ObstaclePrediction]]: |
| def add_r2p2_prediction(point_cloud_stream, obstacles_tracking_stream, | ||
| time_to_decision_stream, lidar_setup): | ||
| def add_r2p2_prediction(point_cloud_stream: Stream[PointCloud], obstacles_tracking_stream: Stream[ObstaclesMessageTuple], | ||
| time_to_decision_stream, lidar_setup: Stream[LidarSetup]) -> Stream[prediction]: |
Member
There was a problem hiding this comment.
Suggested change
| time_to_decision_stream, lidar_setup: Stream[LidarSetup]) -> Stream[prediction]: | |
| time_to_decision_stream: Stream[float], lidar_setup: LidarSetup) -> Stream[List[ObstaclePrediction]]: |
Comment on lines
442
to
443
| tracking_stream: Stream, | ||
| prediction_stream: Stream, |
Member
There was a problem hiding this comment.
Please annotate the types of these streams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.