Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case when lone wildcard is ORed with other constraints #1186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Oct 24, 2024

While working on another feature, I noticed that a constraint like * || 1.2.3 wasn't being normalised to just * as expected. This pull request fixes this oversight.

While working on this change, I noticed that a constraint like *, 1.2.3 isn't normalised to 1.2.3. Let's deal with this in a separate step. (It's late here and I'm tired.)

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (0b0ef26) to head (185a788).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1186   +/-   ##
=========================================
  Coverage     96.49%   96.50%           
- Complexity      196      197    +1     
=========================================
  Files            32       32           
  Lines           828      830    +2     
=========================================
+ Hits            799      801    +2     
  Misses           29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredden fredden marked this pull request as ready for review October 25, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants