Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files to be translated in french Canadian #1893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jadehamel
Copy link

I'm asking for a merge on a W.I.P. so it could be easyier to follow the diff for other contributers...

@slingamn
Copy link
Member

slingamn commented Jan 9, 2022

Thanks, this is great!

@DanielOaks can you take a look at how this interacts with our recommended workflow for translations? Should these preferably be submitted to Crowdin? If we merge this PR here, will Crowdin pick it up?

@jadehamel
Copy link
Author

Thanks, this is great!

@DanielOaks can you take a look at how this interacts with our recommended workflow for translations? Should these preferably be submitted to Crowdin? If we merge this PR here, will Crowdin pick it up?

thank you I was waiting some reviews before to put more work on thoses files.

@progval
Copy link
Contributor

progval commented Jun 11, 2022

I see two issues:

  • The translation for "channel" is inconsistent: 94 occurrences of "salon" and 16 of "canal". Could you use "salon" everywhere (it sounds better IMO)
  • In languages/ca-FR-help.lang.json, you changed the syntax of commands. Spaces, brackets, ..., etc matter there. Also, WHO's syntax is significantly different

Otherwise, it looks good to me (as a French person).

@progval
Copy link
Contributor

progval commented Jun 11, 2022

Oh, I just realized it's an issue in the existing translation... I guess these should be fixed first, then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants