fix: tabview state (#55)

erickzanardo · May 30, 2023 · f1c8c4e · f1c8c4e
1 parent aaf2c9e
commit f1c8c4e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
  - feat: add `NesIcons.zoomOut`
  - feat: add `NesIcons.yamlFile`
  - feat: add `NesIcons.xmlFile`
+ - fix: `NesTabView` didn't keept state on tab change.
 
 # 0.6.0
 

diff --git a/lib/src/widgets/nes_tab_view.dart b/lib/src/widgets/nes_tab_view.dart
@@ -91,22 +91,18 @@ class _NesTabViewState extends State<NesTabView> {
           ),
         ),
         Expanded(
-          child: Stack(
+          child: IndexedStack(
+            index: _selectedIndex,
             children: [
               for (var i = 0; i < widget.tabs.length; i++)
-                Positioned.fill(
-                  child: Visibility(
-                    visible: _selectedIndex == i,
-                    child: CustomPaint(
-                      painter: _NesTabViewPainter(
-                        color: textStyle.color ?? Colors.black,
-                        pixelSize: nesTheme.pixelSize.toDouble(),
-                      ),
-                      child: Padding(
-                        padding: EdgeInsets.all(nesTheme.pixelSize.toDouble()),
-                        child: widget.tabs[i].child,
-                      ),
-                    ),
+                CustomPaint(
+                  painter: _NesTabViewPainter(
+                    color: textStyle.color ?? Colors.black,
+                    pixelSize: nesTheme.pixelSize.toDouble(),
+                  ),
+                  child: Padding(
+                    padding: EdgeInsets.all(nesTheme.pixelSize.toDouble()),
+                    child: widget.tabs[i].child,
                   ),
                 ),
             ],