Skip to content

Conversation

Whaileee
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Oct 13, 2025

CT Test Results

    5 files    172 suites   1h 1m 38s ⏱️
2 090 tests 2 029 ✅ 60 💤 1 ❌
2 805 runs  2 725 ✅ 79 💤 1 ❌

For more details on these failures, see this check.

Results for commit 139440d.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@Whaileee Whaileee force-pushed the whaileee/workflows/ort-update-70.0.1 branch from e016b86 to d978007 Compare October 13, 2025 14:00
@kikofernandez
Copy link
Contributor

I have tested locally ORT 67.1.0 and we need to add the following to the otp/.ort/config/config.yml

ort:
  enableRepositoryPackageCurations: true
  forceOverwrite: true

  licenseFactProviders:    # This is new
    spdx: {}                        # This is new

I took the scan-result.json from https://github.com/erlang/otp/actions/runs/18348071439/job/52260726544 and I seem to generate some "correct" SBOM. I mention "correct" because I did not generate the SBOM using info from reuse, but apart from that, it was ok.

@kikofernandez
Copy link
Contributor

the main issue was reuse getting confused about a comment on licenses.
ORT had no issue. this commit ignores the parts of the md file that should be ignored to not confuse reuse.
The commit that I added also fixes a new configuration option that ORT has introduced recently.
I update the ort-config file, in case using the config file from v59 causes issues because it is not up-to-date with the new v70 that we will be using.

@Whaileee Whaileee force-pushed the whaileee/workflows/ort-update-70.0.1 branch 2 times, most recently from 879201e to bb4af3c Compare October 14, 2025 07:39
@Whaileee Whaileee changed the base branch from master to maint October 14, 2025 07:41
@Whaileee Whaileee changed the base branch from maint to master October 14, 2025 07:42
@Whaileee Whaileee force-pushed the whaileee/workflows/ort-update-70.0.1 branch from bb4af3c to 1640aec Compare October 14, 2025 11:35
@Whaileee Whaileee force-pushed the whaileee/workflows/ort-update-70.0.1 branch from 1640aec to 139440d Compare October 14, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants