otp: fixes windows powershell#11055
Merged
kikofernandez merged 2 commits intoerlang:masterfrom Apr 22, 2026
Merged
Conversation
powershell parses $env:BASENAME.zip as accessing the property .zip on $env:BASENAME. this property does not exist and it was not the intention. this commit assigns the env variable to powershell variable, so any other $basename.zip is interpreted as expanding the variable, and not as accessing a property
Contributor
CT Test Results 1 files 11 suites 2m 58s ⏱️ Results for commit a9b1483. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Whaileee
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
powershell parses
$env:BASENAME.zipas accessing the property.zipon$env:BASENAME. this property does not exist and it was not the intention.this commit assigns the env variable to powershell variable, so any other
$basename.zipis interpreted as expanding the variable, and not as accessing a propertyFixes broken powershell variable expansion from #11000