Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop redirect loops #499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

avtobiff
Copy link
Collaborator

Stop redirects if the server path equals redirect path. This stops redirect loops.

@vinoski
Copy link
Collaborator

vinoski commented Jan 15, 2025

Looks like redirect_with_trailing_slash is failing.

Can we also add a new test for redirect loops?

@avtobiff
Copy link
Collaborator Author

Yes, I mixed up Prefix and Path when creating this change.
Should be fixed in last push.

Wlil work on a test.

Stop redirects if the server path equals redirect prefix path. This
stops redirect loops.
@avtobiff
Copy link
Collaborator Author

Finally using the correct path (the (#arg.req)#http_request.path), but
the redirect is still failing. Needs more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants