This repository was archived by the owner on Jan 22, 2018. It is now read-only.
Fix p4 submit losing changelists. #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'git p4 submit' was updating the p4/master ref and the git-p4 notes after a successful submission. As a result any changes between the last 'git p4 sync' and 'git p4 submit' would not get sync'd upon future 'git p4 syncs' because git-p4 would think that the local repository was sync'd up to the submitted revision. This change does not update the local repository and instead forces you to 'git p4 sync' to sync your new changes from the p4 depot.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'git p4 submit' was updating the p4/master ref and the git-p4 notes
after a successful submission. As a result any changes between the last
'git p4 sync' and 'git p4 submit' would not get sync'd upon future 'git
p4 syncs' because git-p4 would think that the local repository was
sync'd up to the submitted revision. This change does not update the
local repository and instead forces you to 'git p4 sync' to sync your
new changes from the p4 depot.